lkml.org 
[lkml]   [2019]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: linux-next: Tree for Aug 29 (mlx5)
Date
On Thu, 2019-08-29 at 21:48 +0000, Haiyang Zhang wrote:
> > -----Original Message-----
> > From: Saeed Mahameed <saeedm@mellanox.com>
> > Sent: Thursday, August 29, 2019 2:32 PM
> > To: sfr@canb.auug.org.au; Eran Ben Elisha <eranbe@mellanox.com>;
> > linux-
> > next@vger.kernel.org; rdunlap@infradead.org; Haiyang Zhang
> > <haiyangz@microsoft.com>
> > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; Leon
> > Romanovsky <leonro@mellanox.com>
> > Subject: Re: linux-next: Tree for Aug 29 (mlx5)
> >
> > On Thu, 2019-08-29 at 12:55 -0700, Randy Dunlap wrote:
> > > On 8/29/19 12:54 PM, Randy Dunlap wrote:
> > > > On 8/29/19 4:08 AM, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > >
> > > > > Changes since 20190828:
> > > > >
> > > >
> > > > on x86_64:
> > > > when CONFIG_PCI_HYPERV=m
> > >
> > > and CONFIG_PCI_HYPERV_INTERFACE=m
> > >
> >
> > Haiyang and Eran, I think CONFIG_PCI_HYPERV_INTERFACE was never
> > supposed to be a module ? it supposed to provide an always
> > available
> > interface to drivers ..
> >
> > Anyway, maybe we need to imply CONFIG_PCI_HYPERV_INTERFACE in mlx5.
>
> The symbolic dependency by driver mlx5e, automatically triggers
> loading of
> pci_hyperv_interface module. And this module can be loaded in any
> platforms.
>

This only works when both are modules.


> Currently, mlx5e driver has #if
> IS_ENABLED(CONFIG_PCI_HYPERV_INTERFACE)
> around the code using the interface.
>
> I agree --
> Adding "select PCI_HYPERV_INTERFACE" for mlx5e will clean up these
> #if's.
>

No, not "select", "imply".

if one wants PCI_HYPERV_INTERFACE off, imply will keep it off for you.

> Thanks,
> - Haiyang
\
 
 \ /
  Last update: 2019-08-30 01:04    [W:0.098 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site