lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 51/98] drm/vmwgfx: fix memory leak when too many retries have occurred
    Date
    [ Upstream commit 6b7c3b86f0b63134b2ab56508921a0853ffa687a ]

    Currently when too many retries have occurred there is a memory
    leak on the allocation for reply on the error return path. Fix
    this by kfree'ing reply before returning.

    Addresses-Coverity: ("Resource leak")
    Fixes: a9cd9c044aa9 ("drm/vmwgfx: Add a check to handle host message failure")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Reviewed-by: Deepak Rawat <drawat@vmware.com>
    Signed-off-by: Deepak Rawat <drawat@vmware.com>
    Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
    index e4e09d47c5c0e..59e9d05ab928b 100644
    --- a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
    +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
    @@ -389,8 +389,10 @@ static int vmw_recv_msg(struct rpc_channel *channel, void **msg,
    break;
    }

    - if (retries == RETRIES)
    + if (retries == RETRIES) {
    + kfree(reply);
    return -EINVAL;
    + }

    *msg_len = reply_len;
    *msg = reply;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-27 10:36    [W:6.789 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site