lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 008/162] regulator: axp20x: fix DCDC5 and DCDC6 for AXP803
    Date
    [ Upstream commit 8f46e22b5ac692b48d04bb722547ca17b66dda02 ]

    Refactoring of axp20x driver introduced a bug in AXP803's DCDC6
    regulator definition. AXP803_DCDC6_1120mV_STEPS was obtained by
    subtracting 0x47 and 0x33. This should be 0x14 (hex) and not 14
    (dec).

    Refactoring also carried over a bug in DCDC5 regulator definition.
    Number of possible voltages must be for 1 bigger than maximum valid
    voltage index, because 0 is also valid and it means lowest voltage.

    Fixes: 1dbe0ccb0631 ("regulator: axp20x-regulator: add support for AXP803")
    Fixes: db4a555f7c4c ("regulator: axp20x: use defines for masks")
    Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
    Link: https://lore.kernel.org/r/20190713090717.347-3-jernej.skrabec@siol.net
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/axp20x-regulator.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
    index c951568994a11..989506bd90b19 100644
    --- a/drivers/regulator/axp20x-regulator.c
    +++ b/drivers/regulator/axp20x-regulator.c
    @@ -174,14 +174,14 @@
    #define AXP803_DCDC5_1140mV_STEPS 35
    #define AXP803_DCDC5_1140mV_END \
    (AXP803_DCDC5_1140mV_START + AXP803_DCDC5_1140mV_STEPS)
    -#define AXP803_DCDC5_NUM_VOLTAGES 68
    +#define AXP803_DCDC5_NUM_VOLTAGES 69

    #define AXP803_DCDC6_600mV_START 0x00
    #define AXP803_DCDC6_600mV_STEPS 50
    #define AXP803_DCDC6_600mV_END \
    (AXP803_DCDC6_600mV_START + AXP803_DCDC6_600mV_STEPS)
    #define AXP803_DCDC6_1120mV_START 0x33
    -#define AXP803_DCDC6_1120mV_STEPS 14
    +#define AXP803_DCDC6_1120mV_STEPS 20
    #define AXP803_DCDC6_1120mV_END \
    (AXP803_DCDC6_1120mV_START + AXP803_DCDC6_1120mV_STEPS)
    #define AXP803_DCDC6_NUM_VOLTAGES 72
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-27 10:00    [W:7.259 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site