lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 55/98] perf pmu-events: Fix missing "cpu_clk_unhalted.core" event
    Date
    [ Upstream commit 8e6e5bea2e34c61291d00cb3f47560341aa84bc3 ]

    The events defined in pmu-events JSON are parsed and added into perf
    tool. For fixed counters, we handle the encodings between JSON and perf
    by using a static array fixed[].

    But the fixed[] has missed an important event "cpu_clk_unhalted.core".

    For example, on the Tremont platform,

    [root@localhost ~]# perf stat -e cpu_clk_unhalted.core -a
    event syntax error: 'cpu_clk_unhalted.core'
    \___ parser error

    With this patch, the event cpu_clk_unhalted.core can be parsed.

    [root@localhost perf]# ./perf stat -e cpu_clk_unhalted.core -a -vvv
    ------------------------------------------------------------
    perf_event_attr:
    type 4
    size 112
    config 0x3c
    sample_type IDENTIFIER
    read_format TOTAL_TIME_ENABLED|TOTAL_TIME_RUNNING
    disabled 1
    inherit 1
    exclude_guest 1
    ------------------------------------------------------------
    ...

    Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Jin Yao <yao.jin@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/20190729072755.2166-1-yao.jin@linux.intel.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/perf/pmu-events/jevents.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
    index 68c92bb599eef..6b36b71106695 100644
    --- a/tools/perf/pmu-events/jevents.c
    +++ b/tools/perf/pmu-events/jevents.c
    @@ -450,6 +450,7 @@ static struct fixed {
    { "inst_retired.any_p", "event=0xc0" },
    { "cpu_clk_unhalted.ref", "event=0x0,umask=0x03" },
    { "cpu_clk_unhalted.thread", "event=0x3c" },
    + { "cpu_clk_unhalted.core", "event=0x3c" },
    { "cpu_clk_unhalted.thread_any", "event=0x3c,any=1" },
    { NULL, NULL},
    };
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-27 09:59    [W:8.967 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site