lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 51/62] dm space map metadata: fix missing store of apply_bops() return value
    Date
    From: ZhangXiaoxu <zhangxiaoxu5@huawei.com>

    commit ae148243d3f0816b37477106c05a2ec7d5f32614 upstream.

    In commit 6096d91af0b6 ("dm space map metadata: fix occasional leak
    of a metadata block on resize"), we refactor the commit logic to a new
    function 'apply_bops'. But when that logic was replaced in out() the
    return value was not stored. This may lead out() returning a wrong
    value to the caller.

    Fixes: 6096d91af0b6 ("dm space map metadata: fix occasional leak of a metadata block on resize")
    Cc: stable@vger.kernel.org
    Signed-off-by: ZhangXiaoxu <zhangxiaoxu5@huawei.com>
    Signed-off-by: Mike Snitzer <snitzer@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/persistent-data/dm-space-map-metadata.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/md/persistent-data/dm-space-map-metadata.c
    +++ b/drivers/md/persistent-data/dm-space-map-metadata.c
    @@ -248,7 +248,7 @@ static int out(struct sm_metadata *smm)
    }

    if (smm->recursion_count == 1)
    - apply_bops(smm);
    + r = apply_bops(smm);

    smm->recursion_count--;


    \
     
     \ /
      Last update: 2019-08-27 09:54    [W:7.409 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site