Messages in this thread | | | Subject | Re: [PATCH] mtd: hyperbus: fix dependency and build error | From | Vignesh Raghavendra <> | Date | Sat, 24 Aug 2019 19:45:11 +0530 |
| |
Hi Miquel,
On 24-Aug-19 4:18 PM, Miquel Raynal wrote: > Hi Vignesh, > > Randy Dunlap <rdunlap@infradead.org> wrote on Tue, 13 Aug 2019 16:03:13 > -0700: > >> From: Randy Dunlap <rdunlap@infradead.org> >> >> lib/devres.c, which implements devm_ioremap_resource(), is only built >> when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend >> on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on >> UML builds): >> >> WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS >> Depends on [n]: MTD [=m] && HAS_IOMEM [=n] >> Selected by [m]: >> - MTD_HYPERBUS [=m] && MTD [=m] >> >> ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined! >> >> Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Vignesh Raghavendra <vigneshr@ti.com> >> Cc: Miquel Raynal <miquel.raynal@bootlin.com> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org> >> Cc: linux-mtd@lists.infradead.org >> --- > > This patch looks like a good candidate for fixes, shall I send a fixes > PR next week with it? (Acked-by wished) >
Yes, that would be great. I was about to send across patch bundle myself.
Acked-by: Vignesh Raghavendra <vigneshr@ti.com>
Thanks Vignesh
| |