| Date | Sat, 24 Aug 2019 02:41:51 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v5 12/13] pwm: mediatek: remove a property "has-clock" |
| |
On Thu, Aug 22, 2019 at 02:58:42PM +0800, Sam Shih wrote: > Due to we added clock-frequency property to fix > mt7628 pwm during configure from userspace. > We can alos use this property to determine whether > the complex clock tree exists in the SoC or not. > So we can safety remove has-clock property in the > driver specific data.
Some suggestions in short form:
s/Due/Since/ s/alos/also/
Also please use more horizontal space, up to 76 chars per line is fine.
Other than that I suggest to first address the feedback for the earlier patches as the needed changes there has influence on this patch.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
|