lkml.org 
[lkml]   [2019]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] uprobes/x86: fix detection of 32-bit user mode
From
Date


> On Aug 23, 2019, at 4:44 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>
>> On Sat, 24 Aug 2019, Thomas Gleixner wrote:
>>> On Sun, 28 Jul 2019, Sebastian Mayr wrote:
>>>
>>> -static inline int sizeof_long(void)
>>> +static inline int sizeof_long(struct pt_regs *regs)
>>> {
>>> - return in_ia32_syscall() ? 4 : 8;
>>
>> This wants a comment.
>>
>>> + return user_64bit_mode(regs) ? 8 : 4;
>
> The more simpler one liner is to check
>
> test_thread_flag(TIF_IA32)

I still want to finish killing TIF_IA32 some day. Let’s please not add new users.

\
 
 \ /
  Last update: 2019-08-24 01:58    [W:0.070 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site