Messages in this thread | | | Subject | Re: [PATCH] ethernet: Delete unnecessary checks b efore the macro call “dev kfree skb” | From | Scott Branden <> | Date | Fri, 23 Aug 2019 09:10:02 -0700 |
| |
On 2019-08-23 7:08 a.m., Christophe JAILLET wrote: > Hi, > > in this patch, there is one piece that looked better before. (see below) > > Removing the 'if (skb)' is fine, but concatening everything in one > statement just to save 2 variables and a few LOC is of no use, IMHO, > and the code is less readable. Agreed. > > just my 2c. > > > CJ > > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c > b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > index d3a0b614dbfa..8b19ddcdafaa 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c > @@ -2515,19 +2515,14 @@ static int bcmgenet_dma_teardown(struct > bcmgenet_priv *priv) > static void bcmgenet_fini_dma(struct bcmgenet_priv *priv) > { > struct netdev_queue *txq; > - struct sk_buff *skb; > - struct enet_cb *cb; > int i; > > bcmgenet_fini_rx_napi(priv); > bcmgenet_fini_tx_napi(priv); > > - for (i = 0; i < priv->num_tx_bds; i++) { > - cb = priv->tx_cbs + i; > - skb = bcmgenet_free_tx_cb(&priv->pdev->dev, cb); > - if (skb) > - dev_kfree_skb(skb); > - } > + for (i = 0; i < priv->num_tx_bds; i++) > + dev_kfree_skb(bcmgenet_free_tx_cb(&priv->pdev->dev, > + priv->tx_cbs + i)); > > for (i = 0; i < priv->hw_params->tx_queues; i++) { > txq = netdev_get_tx_queue(priv->dev, priv->tx_rings[i].queue);
| |