Messages in this thread | | | Date | Fri, 23 Aug 2019 16:32:41 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] tty/serial: atmel: remove unneeded atmel_get_lines_status function |
| |
On Fri, Aug 23, 2019 at 03:41:09PM +0200, Richard Genoud wrote: > Since commit ce59e48fdbad ("serial: mctrl_gpio: implement interrupt > handling"), the GPIOs interrupts are handled by mctrl_gpio_irq_handle().
Well no, since ce59e48fdbad the mctrl_gpio helper can do all that interrupt stuff. You want to reference 18dfef9c7f87b75bbb0fb66a634f7c13a45b9f8d here.
> So, atmel_get_lines_status() can be completely killed and replaced by : > atmel_uart_readl(port, ATMEL_US_CSR); > > Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |