lkml.org 
[lkml]   [2019]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 07/10] PCI: layerscape: Modify the MSIX to the doorbell way
    On Thu, Aug 22, 2019 at 07:22:39PM +0800, Xiaowei Bao wrote:
    > The layerscape platform use the doorbell way to trigger MSIX
    > interrupt in EP mode.
    >

    I have no problems with this patch, however...

    Are you able to add to this message a reason for why you are making this
    change? Did dw_pcie_ep_raise_msix_irq not work when func_no != 0? Or did
    it work yet dw_pcie_ep_raise_msix_irq_doorbell is more efficient?

    Thanks,

    Andrew Murray

    > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
    > ---
    > v2:
    > - No change.
    >
    > drivers/pci/controller/dwc/pci-layerscape-ep.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
    > index 8461f62..7ca5fe8 100644
    > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
    > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
    > @@ -74,7 +74,8 @@ static int ls_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
    > case PCI_EPC_IRQ_MSI:
    > return dw_pcie_ep_raise_msi_irq(ep, func_no, interrupt_num);
    > case PCI_EPC_IRQ_MSIX:
    > - return dw_pcie_ep_raise_msix_irq(ep, func_no, interrupt_num);
    > + return dw_pcie_ep_raise_msix_irq_doorbell(ep, func_no,
    > + interrupt_num);
    > default:
    > dev_err(pci->dev, "UNKNOWN IRQ type\n");
    > return -EINVAL;
    > --
    > 2.9.5
    >

    \
     
     \ /
      Last update: 2019-08-23 15:59    [W:4.157 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site