lkml.org 
[lkml]   [2019]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 27/78] ALSA: firewire: fix a memory leak bug
    Date
    From: Wenwen Wang <wenwen@cs.uga.edu>

    commit 1be3c1fae6c1e1f5bb982b255d2034034454527a upstream.

    In iso_packets_buffer_init(), 'b->packets' is allocated through
    kmalloc_array(). Then, the aligned packet size is checked. If it is
    larger than PAGE_SIZE, -EINVAL will be returned to indicate the error.
    However, the allocated 'b->packets' is not deallocated on this path,
    leading to a memory leak.

    To fix the above issue, free 'b->packets' before returning the error code.

    Fixes: 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin FireWave Surround driver")
    Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
    Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
    Cc: <stable@vger.kernel.org> # v2.6.39+
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/firewire/packets-buffer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/firewire/packets-buffer.c
    +++ b/sound/firewire/packets-buffer.c
    @@ -37,7 +37,7 @@ int iso_packets_buffer_init(struct iso_p
    packets_per_page = PAGE_SIZE / packet_size;
    if (WARN_ON(!packets_per_page)) {
    err = -EINVAL;
    - goto error;
    + goto err_packets;
    }
    pages = DIV_ROUND_UP(count, packets_per_page);


    \
     
     \ /
      Last update: 2019-08-22 19:51    [W:2.086 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site