lkml.org 
[lkml]   [2019]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 046/135] xen/pciback: remove set but not used variable 'old_state'
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit 09e088a4903bd0dd911b4f1732b250130cdaffed ]

    Fixes gcc '-Wunused-but-set-variable' warning:

    drivers/xen/xen-pciback/conf_space_capability.c: In function pm_ctrl_write:
    drivers/xen/xen-pciback/conf_space_capability.c:119:25: warning:
    variable old_state set but not used [-Wunused-but-set-variable]

    It is never used so can be removed.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/xen/xen-pciback/conf_space_capability.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c
    index 73427d8e01161..e5694133ebe57 100644
    --- a/drivers/xen/xen-pciback/conf_space_capability.c
    +++ b/drivers/xen/xen-pciback/conf_space_capability.c
    @@ -116,13 +116,12 @@ static int pm_ctrl_write(struct pci_dev *dev, int offset, u16 new_value,
    {
    int err;
    u16 old_value;
    - pci_power_t new_state, old_state;
    + pci_power_t new_state;

    err = pci_read_config_word(dev, offset, &old_value);
    if (err)
    goto out;

    - old_state = (pci_power_t)(old_value & PCI_PM_CTRL_STATE_MASK);
    new_state = (pci_power_t)(new_value & PCI_PM_CTRL_STATE_MASK);

    new_value &= PM_OK_BITS;
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-08-22 19:26    [W:5.541 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site