lkml.org 
[lkml]   [2019]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 10/12] phy: amlogic: G12A: Fix misuse of GENMASK macro
    From
    Date


    On 22/07/19 12:53 PM, Neil Armstrong wrote:
    > On 10/07/2019 07:04, Joe Perches wrote:
    >> Arguments are supposed to be ordered high then low.
    >>
    >> Signed-off-by: Joe Perches <joe@perches.com>
    >> ---
    >> drivers/phy/amlogic/phy-meson-g12a-usb2.c | 2 +-
    >> 1 file changed, 1 insertion(+), 1 deletion(-)
    >>
    >> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
    >> index 9065ffc85eb4..cd7eccab2649 100644
    >> --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c
    >> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
    >> @@ -66,7 +66,7 @@
    >> #define PHY_CTRL_R14 0x38
    >> #define PHY_CTRL_R14_I_RDP_EN BIT(0)
    >> #define PHY_CTRL_R14_I_RPU_SW1_EN BIT(1)
    >> - #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(2, 3)
    >> + #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(3, 2)
    >> #define PHY_CTRL_R14_PG_RSTN BIT(4)
    >> #define PHY_CTRL_R14_I_C2L_DATA_16_8 BIT(5)
    >> #define PHY_CTRL_R14_I_C2L_ASSERT_SINGLE_EN_ZERO BIT(6)
    >>
    >
    > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

    Shouldn't this go to stable trees as well?

    -Kishon

    \
     
     \ /
      Last update: 2019-08-23 04:42    [W:2.374 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site