lkml.org 
[lkml]   [2019]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/4] misc: xilinx_sdfec: Return -EFAULT if copy_from_user() fails
    From
    Date
    On 21. 08. 19 9:07, Dan Carpenter wrote:
    > The copy_from_user() funciton returns the number of bytes remaining to

    typo here.

    > be copied but we want to return -EFAULT to the user.
    >
    > Fixes: 20ec628e8007 ("misc: xilinx_sdfec: Add ability to configure LDPC")
    > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    > ---
    > drivers/misc/xilinx_sdfec.c | 5 +++--
    > 1 file changed, 3 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
    > index dc1b8b412712..813b82c59360 100644
    > --- a/drivers/misc/xilinx_sdfec.c
    > +++ b/drivers/misc/xilinx_sdfec.c
    > @@ -651,9 +651,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg)
    > if (!ldpc)
    > return -ENOMEM;
    >
    > - ret = copy_from_user(ldpc, arg, sizeof(*ldpc));
    > - if (ret)
    > + if (copy_from_user(ldpc, arg, sizeof(*ldpc))) {
    > + ret = -EFAULT;
    > goto err_out;
    > + }
    >
    > if (xsdfec->config.code == XSDFEC_TURBO_CODE) {
    > ret = -EIO;
    >

    When typo fixed feel free to add my
    Reviewed-by: Michal Simek <michal.simek@xilinx.com>

    Thanks,
    Michal

    \
     
     \ /
      Last update: 2019-08-22 10:17    [W:5.250 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site