lkml.org 
[lkml]   [2019]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 24/25] perf c2c: Fix report with offline cpus
    Date
    From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>

    If c2c is recorded on a machine where any cpus are offline, 'perf c2c
    report' throws an error "node/cpu topology bugFailed setup nodes".

    It fails because while preparing node-cpu mapping we don't consider
    offline cpus.

    Reported-by: Nageswara R Sastry <nasastry@in.ibm.com>
    Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
    Acked-by: Jiri Olsa <jolsa@kernel.org>
    Fixes: 1e181b92a2da ("perf c2c report: Add 'node' sort key")
    Link: http://lkml.kernel.org/r/20190822085045.25108-1-ravi.bangoria@linux.ibm.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-c2c.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
    index 01629f5b6d1f..211143720078 100644
    --- a/tools/perf/builtin-c2c.c
    +++ b/tools/perf/builtin-c2c.c
    @@ -2027,7 +2027,7 @@ static int setup_nodes(struct perf_session *session)
    c2c.node_info = 2;

    c2c.nodes_cnt = session->header.env.nr_numa_nodes;
    - c2c.cpus_cnt = session->header.env.nr_cpus_online;
    + c2c.cpus_cnt = session->header.env.nr_cpus_avail;

    n = session->header.env.numa_nodes;
    if (!n)
    --
    2.21.0
    \
     
     \ /
      Last update: 2019-08-22 23:26    [W:6.937 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site