Messages in this thread | | | Subject | Re: [PATCH 1/1] netfilter: nf_tables: fib: Drop IPV6 packages if IPv6 is disabled on boot | From | Leonardo Bras <> | Date | Tue, 20 Aug 2019 13:15:58 -0300 |
| |
On Tue, 2019-08-20 at 07:36 +0200, Florian Westphal wrote: > Wouldn't fib_netdev.c have the same problem? Probably, but I haven't hit this issue yet.
> If so, might be better to place this test in both > nft_fib6_eval_type and nft_fib6_eval. I think that is possible, and not very hard to do.
But in my humble viewpoint, it looks like it's nft_fib_inet_eval() and nft_fib_netdev_eval() have the responsibility to choose a valid protocol or drop the package. I am not sure if it would be a good move to transfer this responsibility to nft_fib6_eval_type() and nft_fib6_eval(), so I would rather add the same test to nft_fib_netdev_eval().
Does it make sense?
Thanks for the feedback!
Leonardo Bras
[unhandled content-type:application/pgp-signature] | |