Messages in this thread | | | From | <> | Subject | Re: [PATCH v2] mtd: spi-nor: fix a memory leak bug | Date | Tue, 20 Aug 2019 14:54:34 +0000 |
| |
On 08/19/2019 08:16 PM, Wenwen Wang wrote: > External E-Mail > > > In spi_nor_parse_4bait(), 'dwords' is allocated through kmalloc(). However, > it is not deallocated in the following execution if spi_nor_read_sfdp() > fails, leading to a memory leak. To fix this issue, free 'dwords' before > returning the error. > > Fixes: 816873eaeec6 ("mtd: spi-nor: parse SFDP 4-byte Address Instruction > Table") >
^ Miquel, maybe you can drop this new line when applying.
> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
This is a good candidate for mtd/fixes, so:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
| |