lkml.org 
[lkml]   [2019]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY
On Tue, Aug 20, 2019 at 04:56:02PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote:

> > +#define DR_TY_50OHM(x) ((~(x) << 28) & DR_TY_MASK)
>
> For consistency it should be
>
> #define DR_TY_SHIFT(x) (((x) << 28) & DR_TY_MASK)
>
> with explanation about 50 Ohm in the code below.

> > + /* Drive impedance: 50 Ohm */
>
> Nice, you have already a comment here. Just use DR_TY_SHIFT(1)

It should be DR_TY_SHIFT(6) now since I dropped the negation.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-08-20 16:00    [W:0.072 / U:1.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site