Messages in this thread | | | Date | Tue, 20 Aug 2019 15:08:35 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [patch 03/44] posix-timer: Use a callback for cancel synchronization |
| |
On Mon, 19 Aug 2019, Christoph Hellwig wrote:
> > + if (!WARN_ON_ONCE(kc->timer_wait_running)) > > + kc->timer_wait_running(timer); > > This looks weird. The only place calling yor new method only does so > after checking that it is not set and actually warns if it set?
Yeah, that wants to be;
if (!WARN_ON_ONCE(!kc->timer_wait_running)) kc->timer_wait_running(timer);
| |