| Date | Tue, 20 Aug 2019 11:23:37 +0200 | From | Petr Mladek <> | Subject | Re: [RFC PATCH v4 4/9] printk-rb: initialize new descriptors as invalid |
| |
On Thu 2019-08-08 00:32:29, John Ogness wrote: > Initialize never-used descriptors as permanently invalid so there
The word "permanently" is confusing. It suggests that it will never ever be valid again. I would just remove the word.
> is no risk of the descriptor unexpectedly being determined as > valid due to dataring head overflowing/wrapping.
Please, provide more details about the solved race. Is it because some reader could have reference to an invalid (reused) descriptor? Can be these invalid descriptors be member of the list?
Also it might be worth to mention where is the check that might detect such invalid descriptors and what will be the consequences. Well, this might be clear from the race description.
Best Regards, Petr
|