Messages in this thread | | | Subject | Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name | From | "Tanwar, Rahul" <> | Date | Wed, 21 Aug 2019 11:21:43 +0800 |
| |
On 20/8/2019 10:57 PM, Peter Zijlstra wrote: > On Tue, Aug 20, 2019 at 12:48:05PM +0000, Luck, Tony wrote: >>>> +#define INTEL_FAM6_ATOM_AIRMONT_NP 0x75 /* Lightning Mountain */ >>> What's _NP ? >> Network Processor. But that is too narrow a descriptor. This is going to be used in >> other areas besides networking. >> >> I’m contemplating calling it AIRMONT2 > What would describe the special sause that warranted a new SOC? If this > thing is marketed as 'Network Processor' then I suppose we can actually > use it, esp. if we're going to see this more, like the MID thing -- that > lived for a while over multiple uarchs. > > Note that for the big cores we added the NNPI thing, which was for > Neural Network Processing something.
INTEL_FAM6_ATOM_AIRMONT_NP was used keeping in mind the recommended
symbol naming form i.e. INTEL_FAM6{OPTFAMILY}_{MICROARCH}{OPTDIFF}
where OPTDIFF is supposed to be the market segment.
This SoC uses AMT (Admantium/Airmont) configuration which is supposed to be
a higher configuration. Looking at other existing examples, it seems that
INTEL_FAM6_ATOM_AIRMONT_PLUS is most appropriate. Would you have any
concerns with _PLUS name ? Thanks.
| |