Messages in this thread | | | From | Haiyang Zhang <> | Subject | RE: [PATCH net-next,v2 2/6] PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface | Date | Tue, 20 Aug 2019 23:00:22 +0000 |
| |
> -----Original Message----- > From: David Miller <davem@davemloft.net> > Sent: Tuesday, August 20, 2019 3:29 PM > To: Haiyang Zhang <haiyangz@microsoft.com> > Cc: sashal@kernel.org; saeedm@mellanox.com; leon@kernel.org; > eranbe@mellanox.com; lorenzo.pieralisi@arm.com; bhelgaas@google.com; > linux-pci@vger.kernel.org; linux-hyperv@vger.kernel.org; > netdev@vger.kernel.org; KY Srinivasan <kys@microsoft.com>; Stephen > Hemminger <sthemmin@microsoft.com>; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next,v2 2/6] PCI: hv: Add a Hyper-V PCI interface > driver for software backchannel interface > > From: Haiyang Zhang <haiyangz@microsoft.com> > Date: Mon, 19 Aug 2019 19:30:47 +0000 > > > +static void __exit exit_hv_pci_intf(void) { > > + pr_info("unloaded\n"); > > +} > > + > > +static int __init init_hv_pci_intf(void) { > > + pr_info("loaded\n"); > > + > > Clogging up the logs with useless messages like this is inappropriate. > Please remove these pr_info() calls. > > Also, all of these symbols should probably be GPL exported.
I will update the patch -- remove the pr_info, and use EXPORT_SYMBOL_GPL() for the symbols.
Thanks, - Haiyang
| |