lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2] net: phy: broadcom: add 1000Base-X support for BCM54616S
> +static int bcm54616s_read_status(struct phy_device *phydev)
> +{
> + int err;
> +
> + err = genphy_read_status(phydev);
> +
> + /* 1000Base-X register set doesn't provide speed fields: the
> + * link speed is always 1000 Mb/s as long as link is up.
> + */
> + if (phydev->dev_flags & PHY_BCM_FLAGS_MODE_1000BX &&
> + phydev->link)
> + phydev->speed = SPEED_1000;
> +
> + return err;
> +}

This function is equivalent to bcm5482_read_status(). You should use
it, rather than add a new function.

Andrew

\
 
 \ /
  Last update: 2019-08-02 16:50    [W:0.051 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site