Messages in this thread | | | Date | Fri, 2 Aug 2019 16:50:11 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2] net: phy: broadcom: add 1000Base-X support for BCM54616S |
| |
> +static int bcm54616s_read_status(struct phy_device *phydev) > +{ > + int err; > + > + err = genphy_read_status(phydev); > + > + /* 1000Base-X register set doesn't provide speed fields: the > + * link speed is always 1000 Mb/s as long as link is up. > + */ > + if (phydev->dev_flags & PHY_BCM_FLAGS_MODE_1000BX && > + phydev->link) > + phydev->speed = SPEED_1000; > + > + return err; > +}
This function is equivalent to bcm5482_read_status(). You should use it, rather than add a new function.
Andrew
| |