lkml.org 
[lkml]   [2019]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 11/17] net: sgi: ioc3-eth: no need to stop queue set_multicast_list
    Date
    netif_stop_queue()/netif_wake_qeue() aren't needed for changing
    multicast filters. Use spinlocks instead for proper protection
    of private struct.

    Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
    ---
    drivers/net/ethernet/sgi/ioc3-eth.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c
    index d862f28887f9..7f85a3bfef14 100644
    --- a/drivers/net/ethernet/sgi/ioc3-eth.c
    +++ b/drivers/net/ethernet/sgi/ioc3-eth.c
    @@ -1542,8 +1542,7 @@ static void ioc3_set_multicast_list(struct net_device *dev)
    struct netdev_hw_addr *ha;
    u64 ehar = 0;

    - netif_stop_queue(dev); /* Lock out others. */
    -
    + spin_lock_irq(&ip->ioc3_lock);
    if (dev->flags & IFF_PROMISC) { /* Set promiscuous. */
    ip->emcr |= EMCR_PROMISC;
    writel(ip->emcr, &regs->emcr);
    @@ -1572,7 +1571,7 @@ static void ioc3_set_multicast_list(struct net_device *dev)
    writel(ip->ehar_l, &regs->ehar_l);
    }

    - netif_wake_queue(dev); /* Let us get going again. */
    + spin_unlock_irq(&ip->ioc3_lock);
    }

    module_pci_driver(ioc3_driver);
    --
    2.13.7
    \
     
     \ /
      Last update: 2019-08-19 18:56    [W:4.036 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site