Messages in this thread | | | Date | Mon, 19 Aug 2019 11:16:39 -0400 | From | Vivien Didelot <> | Subject | Re: [PATCH net-next 2/3] net: dsa: mv88e6xxx: extend PTP gettime function to read system clock |
| |
On Mon, 19 Aug 2019 15:27:33 +0200, Andrew Lunn <andrew@lunn.ch> wrote: > > @@ -45,7 +45,8 @@ static int mv88e6xxx_smi_direct_write(struct mv88e6xxx_chip *chip, > > { > > int ret; > > > > - ret = mdiobus_write_nested(chip->bus, dev, reg, data); > > + ret = mdiobus_write_sts_nested(chip->bus, dev, reg, data, > > + chip->ptp_sts); > > if (ret < 0) > > return ret; > > > > Please also make a similar change to mv88e6xxx_smi_indirect_write(). > The last write in that function should be timestamped. > > Vivien, please could you think about these changes with respect to > RMU. We probably want to skip the RMU in this case, so we get slow but > uniform jitter, vs fast and unpredictable jitter from using the RMU.
The RMU will have its own mv88e6xxx_bus_ops.
| |