Messages in this thread | | | Subject | Re: [PATCH RESEND v4 5/9] KVM: VMX: Add init/set/get functions for SPP | From | Paolo Bonzini <> | Date | Mon, 19 Aug 2019 17:05:22 +0200 |
| |
On 14/08/19 09:03, Yang Weijiang wrote: > + > +int kvm_mmu_get_subpages(struct kvm *kvm, struct kvm_subpage *spp_info, > + bool mmu_locked) > +{ > + u32 *access = spp_info->access_map; > + gfn_t gfn = spp_info->base_gfn; > + int npages = spp_info->npages; > + struct kvm_memory_slot *slot; > + int i; > + int ret; > + > + if (!kvm->arch.spp_active) > + return -ENODEV; > + > + if (!mmu_locked) > + spin_lock(&kvm->mmu_lock); > +
Do not add this argument. Just lock mmu_lock in the callers.
Paolo
| |