Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 19 Aug 2019 15:45:54 +0200 | Subject | Re: [PATCH v2 01/19] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation |
| |
Hi Jacopo,
On Mon, Jul 8, 2019 at 9:58 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Sat, Jul 6, 2019 at 4:07 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > > Add device tree bindings documentation for the Renesas R-Car Display > > Unit Color Management Module. > > > > CMM is the image enhancement module available on each R-Car DU video > > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > > @@ -0,0 +1,25 @@ > > +* Renesas R-Car Color Management Module (CMM) > > + > > +Renesas R-Car image enhancement module connected to R-Car DU video channels. > > + > > +Required properties: > > + - compatible: shall be one of: > > + - "renesas,rcar-gen3-cmm" > > + - "renesas,rcar-gen2-cmm" > > Why do you think you do not need SoC-specific compatible values? > What if you discover a different across the R-Car Gen3 line tomorrow? > Does the IP block have a version register?
Do you have an answer to these questions? Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |