Messages in this thread | | | Date | Mon, 19 Aug 2019 12:46:16 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH v2 2/2] drm: bridge: adv7511: Add support for ADV7535 |
| |
Hi Bogdan.
> > > adv7533_detach_dsi(adv7511); > > > i2c_unregister_device(adv7511->i2c_cec); > > > if (adv7511->cec_clk) > > > @@ -1266,8 +1278,9 @@ static const struct i2c_device_id > > > adv7511_i2c_ids[] = { > > > { "adv7511", ADV7511 }, > > > { "adv7511w", ADV7511 }, > > > { "adv7513", ADV7511 }, > > > -#ifdef CONFIG_DRM_I2C_ADV7533 > > > +#ifdef CONFIG_DRM_I2C_ADV753x > > > { "adv7533", ADV7533 }, > > > + { "adv7535", ADV7535 }, > > > #endif > > > > This ifdef may not be needed?? > > If we did not get this type we will not look it up. > But if we have defined in DT adv7533/5 device but > CONFIG_DRM_I2C_ADV753x not selected probe will fail with ENODEV. That > would be ok?
What do we gain from this complexity in the end. Why not let the driver always support all variants.
If this result in a simpler driver, and less choices in Kconfig then it is a win-win.
Sam
| |