lkml.org 
[lkml]   [2019]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 10/15] drivers/acrn: add interrupt injection support
From
Date


On 2019年08月16日 21:12, Dan Carpenter wrote:
> On Fri, Aug 16, 2019 at 10:25:51AM +0800, Zhao Yakui wrote:
>> + case IC_VM_INTR_MONITOR: {
>> + struct page *page;
>> +
>> + ret = get_user_pages_fast(ioctl_param, 1, 1, &page);
>> + if (unlikely(ret != 1) || !page) {
> ^^^^^^^^
> Not required.

Do you mean that it is enough to check the condition of "ret != 1"?
OK. It will be removed.


>
>> + pr_err("acrn-dev: failed to pin intr hdr buffer!\n");
>> + return -ENOMEM;
>> + }
>> +
>> + ret = hcall_vm_intr_monitor(vm->vmid, page_to_phys(page));
>> + if (ret < 0) {
>> + pr_err("acrn-dev: monitor intr data err=%ld\n", ret);
>> + return -EFAULT;
>> + }
>> + break;
>> + }
>> +
>
> regards,
> dan carpenter
>

\
 
 \ /
  Last update: 2019-08-19 07:07    [W:0.364 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site