lkml.org 
[lkml]   [2019]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid pointers for %pD
    On Fri 2019-08-09 10:56:04,  Justin He (Arm Technology China)  wrote:
    >
    >
    > > -----Original Message-----
    > > From: Andy Shevchenko <andy.shevchenko@gmail.com>
    > > Sent: 2019年8月9日 18:52
    > > To: Justin He (Arm Technology China) <Justin.He@arm.com>
    > > Cc: Petr Mladek <pmladek@suse.com>; Andy Shevchenko
    > > <andriy.shevchenko@linux.intel.com>; Sergey Senozhatsky
    > > <sergey.senozhatsky@gmail.com>; Geert Uytterhoeven
    > > <geert+renesas@glider.be>; Linux Kernel Mailing List <linux-
    > > kernel@vger.kernel.org>; Thomas Gleixner <tglx@linutronix.de>; Steven
    > > Rostedt (VMware) <rostedt@goodmis.org>; Kees Cook
    > > <keescook@chromium.org>; Shuah Khan <shuah@kernel.org>; Tobin C.
    > > Harding <tobin@kernel.org>
    > > Subject: Re: [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid
    > > pointers for %pD
    > >
    > > On Fri, Aug 9, 2019 at 4:28 AM Jia He <justin.he@arm.com> wrote:
    > > >
    > > > Commit 3e5903eb9cff ("vsprintf: Prevent crash when dereferencing
    > > invalid
    > > > pointers") prevents most crash except for %pD.
    > > > There is an additional pointer dereferencing before dentry_name.
    > > >
    > > > At least, vma->file can be NULL and be passed to printk %pD in
    > > > print_bad_pte, which can cause crash.
    > > >
    > > > This patch fixes it with introducing a new file_dentry_name.
    > > >
    > >
    > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    > >
    > > Perhaps you need to add a Fixes tag
    > Thanks, Andy
    > Fixes: 3e5903eb9cff ("vsprintf: Prevent crash when dereferencing invalid pointers")

    I have added the Fixes tag and pushed the patch into printk.git,
    branch for-5.4.

    Thanks for the fix.

    Best Regards,
    Petr

    \
     
     \ /
      Last update: 2019-08-16 10:20    [W:6.889 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site