lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] afs: Move comments after /* fallthrough */
Date
Joe Perches <joe@perches.com> wrote:

> Make the code a bit easier for a script to appropriately convert
> case statement blocks with /* fallthrough */ comments to a macro by
> moving comments describing the next case block to the case statement.

This doesn't sound good. Can you give an illustration of what a resulting
case might look like? Say taking the following as an example:

> @@ -282,10 +282,8 @@ static int afs_deliver_cb_callback(struct afs_call *call)
> case 0:
> afs_extract_to_tmp(call);
> call->unmarshall++;
> -
> - /* extract the FID array and its count in two steps */
> /* fall through */
> - case 1:
> + case 1: /* extract the FID array and its count in two steps */
> _debug("extract FID count");
> ret = afs_extract_data(call, true);
> if (ret < 0)

David

\
 
 \ /
  Last update: 2019-08-15 15:43    [W:0.115 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site