lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/5] counter: new TI eQEP driver
On Wed, Aug 07, 2019 at 02:40:21PM -0500, David Lechner wrote:
> +static struct counter_synapse ti_eqep_position_synapses[] = {
> + {
> + .action = TI_EQEP_SYNAPSE_ACTION_BOTH_EDGES,
> + .actions_list = ti_eqep_position_synapse_actions,
> + .num_actions = ARRAY_SIZE(ti_eqep_position_synapse_actions),
> + .signal = &ti_eqep_signals[TI_EQEP_SIGNAL_QEPA],
> + },
> + {
> + .action = TI_EQEP_SYNAPSE_ACTION_BOTH_EDGES,
> + .actions_list = ti_eqep_position_synapse_actions,
> + .num_actions = ARRAY_SIZE(ti_eqep_position_synapse_actions),
> + .signal = &ti_eqep_signals[TI_EQEP_SIGNAL_QEPB],
> + },
> +};

Hi David,

Just a minor suggestion for your v3: you don't need to initialize
"action" here since it'll be automatically updated in the core
counter_action_show function to the value returned by your action_get
callback function. So you can safely delete those two ".action =" lines.

William Breathitt Gray

\
 
 \ /
  Last update: 2019-08-15 14:41    [W:0.722 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site