Messages in this thread | | | Date | Thu, 15 Aug 2019 11:49:22 +0200 | From | Pavel Machek <> | Subject | Re: [PATCHv2] USB: serial: option: Add Motorola modem UARTs |
| |
On Thu 2019-08-15 01:26:02, Tony Lindgren wrote: > On Motorola Mapphone devices such as Droid 4 there are five USB ports > that do not use the same layout as Gobi 1K/2K/etc devices listed in > qcserial.c. So we should use qcaux.c or option.c as noted by > Dan Williams <dan.j.williams@intel.com>. > > As the Motorola USB serial ports have an interrupt endpoint as shown > with lsusb -v, we should use option.c instead of qcaux.c as pointed out > by Johan Hovold <johan@kernel.org>. > > The ff/ff/ff interfaces seem to always be UARTs on Motorola devices. > For the other interfaces, class 0x0a (CDC Data) should not in general > be added as they are typically part of a multi-interface function as > noted earlier by Bjørn Mork <bjorn@mork.no>.
Acked-by: Pavel Machek <pavel@ucw.cz> > Cc: Sebastian Reichel <sre@kernel.org> > Tested-by: Pavel Machek <pavel@ucw.cz> > Signed-off-by: Tony Lingren <tony@atomide.com>
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |