lkml.org 
[lkml]   [2019]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 47/91] allocate_flower_entry: should check for null deref
    Date
    [ Upstream commit bb1320834b8a80c6ac2697ab418d066981ea08ba ]

    allocate_flower_entry does not check for allocation success, but tries
    to deref the result. I only moved the spin_lock under null check, because
    the caller is checking allocation's status at line 652.

    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
    index f2aba5b160c2d..d45c435a599d6 100644
    --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
    +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
    @@ -67,7 +67,8 @@ static struct ch_tc_pedit_fields pedits[] = {
    static struct ch_tc_flower_entry *allocate_flower_entry(void)
    {
    struct ch_tc_flower_entry *new = kzalloc(sizeof(*new), GFP_KERNEL);
    - spin_lock_init(&new->lock);
    + if (new)
    + spin_lock_init(&new->lock);
    return new;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-14 19:11    [W:7.161 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site