Messages in this thread | | | Date | Wed, 14 Aug 2019 11:48:28 +0530 | From | Sanyog Kale <> | Subject | Re: [alsa-devel] [PATCH v2 0/3] soundwire: debugfs support for 5.4 |
| |
On Mon, Aug 12, 2019 at 06:59:39PM -0500, Pierre-Louis Bossart wrote: > This patchset enables debugfs support and corrects all the feedback > provided on an earlier RFC ('soundwire: updates for 5.4') > > There is one remaining hard-coded value in intel.c that will need to > be fixed in a follow-up patchset not specific to debugfs: we need to > remove hard-coded Intel-specific configurations from cadence_master.c > (PDI offsets, etc). > > Changes since v1 (Feedback from GKH) > Handle debugfs in a more self-contained way (no dentry as return or parameter) > Used CONFIG_DEBUG_FS in structures and code to make it easier to > remove if need be. > No functional change for register dumps. > > Changes since RFC (Feedback from GKH, Vinod, Guennadi, Cezary, Sanyog): > removed error checks > used DEFINE_SHOW_ATTRIBUTE and seq_file > fixed copyright dates > fixed SPDX license info to use GPL2.0 only > fixed Makefile to include debugfs only if CONFIG_DEBUG_FS is selected > used static inlines for fallback compilation > removed intermediate variables > removed hard-coded constants in loops (used registers offsets and > hardware capabilities) > squashed patch 3 >
Changes looks good to me.
Acked-by: Sanyog Kale <sanyog.r.kale@intel.com>
> _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
| |