Messages in this thread | | | Date | Wed, 14 Aug 2019 12:49:41 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v4 4/8] printk: Replace strncmp with str_has_prefix |
| |
On Fri 2019-08-09 15:10:34, Chuhong Yuan wrote: > strncmp(str, const, len) is error-prone because len > is easy to have typo. > The example is the hard-coded len has counting error > or sizeof(const) forgets - 1. > So we prefer using newly introduced str_has_prefix() > to substitute such strncmp to make code better. > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |