Messages in this thread | | | Subject | Re: [PATCH] x86/fixmap: update stale comments | From | Cao jin <> | Date | Thu, 15 Aug 2019 10:44:33 +0800 |
| |
Hi, Wish to know whether the patch make sense.
On 8/9/19 7:46 PM, Cao jin wrote: > Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> > --- > arch/x86/include/asm/fixmap.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h > index 9da8cccdf3fb..0c47aa82e2e2 100644 > --- a/arch/x86/include/asm/fixmap.h > +++ b/arch/x86/include/asm/fixmap.h > @@ -42,8 +42,7 @@ > * Because of this, FIXADDR_TOP x86 integration was left as later work. > */ > #ifdef CONFIG_X86_32 > -/* used by vmalloc.c, vsyscall.lds.S. > - * > +/*
Not seeing variable __FIXADDR_TOP & macro FIXADDR_TOP under CONFIG_X86_32 referred in vmalloc.c, and there is no vsyscall.lds.S now.
> * Leave one empty page between vmalloc'ed areas and > * the start of the fixmap. > */ > @@ -120,7 +119,7 @@ enum fixed_addresses { > * before ioremap() is functional. > * > * If necessary we round it up to the next 512 pages boundary so > - * that we can have a single pgd entry and a single pte table: > + * that we can have a single pmd entry and a single pte table:
The comments seems missed to be updated in an ancient commit 551889a6e2a24 > */ > #define NR_FIX_BTMAPS 64 > #define FIX_BTMAPS_SLOTS 8 >
-- Sincerely, Cao jin
| |