Messages in this thread | | | Date | Wed, 14 Aug 2019 17:19:52 -0700 | From | Sean Christopherson <> | Subject | Re: [PATCH v4 2/7] x86: kvm: svm: propagate errors from skip_emulated_instruction() |
| |
On Wed, Aug 14, 2019 at 11:34:52AM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson <sean.j.christopherson@intel.com> writes: > > > x86_emulate_instruction() doesn't set vcpu->run->exit_reason when emulation > > fails with EMULTYPE_SKIP, i.e. this will exit to userspace with garbage in > > the exit_reason. > > Oh, nice catch, will take a look!
Don't worry about addressing this. Paolo has already queued the series, and I've got a patch set waiting that purges emulation_result entirely that I'll post once your series hits kvm/queue.
| |