Messages in this thread | | | Subject | Re: [PATCH v3 hmm 01/11] mm/mmu_notifiers: hoist do_mmu_notifier_register down_write to the caller | From | Ralph Campbell <> | Date | Wed, 14 Aug 2019 13:14:24 -0700 |
| |
On 8/6/19 4:15 PM, Jason Gunthorpe wrote: > From: Jason Gunthorpe <jgg@mellanox.com> > > This simplifies the code to not have so many one line functions and extra > logic. __mmu_notifier_register() simply becomes the entry point to > register the notifier, and the other one calls it under lock. > > Also add a lockdep_assert to check that the callers are holding the lock > as expected. > > Suggested-by: Christoph Hellwig <hch@infradead.org> > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Nice clean up. Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
| |