lkml.org 
[lkml]   [2019]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 28/91] usb: typec: tcpm: remove tcpm dir if no children
    Date
    From: Li Jun <jun.li@nxp.com>

    commit 12ca7297b8855c0af1848503d37196159b24e6b9 upstream.

    If config tcpm as module, module unload will not remove tcpm dir,
    then the next module load will have problem: the rootdir is NULL
    but tcpm dir is still there, so tcpm_debugfs_init() will create
    tcpm dir again with failure, fix it by remove the tcpm dir if no
    children.

    Cc: stable@vger.kernel.org # v4.15+
    Fixes: 4b4e02c83167 ("typec: tcpm: Move out of staging")
    Signed-off-by: Li Jun <jun.li@nxp.com>
    Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    Link: https://lore.kernel.org/r/20190717080646.30421-2-jun.li@nxp.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/typec/tcpm.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/usb/typec/tcpm.c
    +++ b/drivers/usb/typec/tcpm.c
    @@ -595,6 +595,10 @@ static void tcpm_debugfs_exit(struct tcp
    mutex_unlock(&port->logbuffer_lock);

    debugfs_remove(port->dentry);
    + if (list_empty(&rootdir->d_subdirs)) {
    + debugfs_remove(rootdir);
    + rootdir = NULL;
    + }
    }

    #else

    \
     
     \ /
      Last update: 2019-08-14 19:27    [W:4.036 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site