lkml.org 
[lkml]   [2019]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 110/144] test_firmware: fix a memory leak bug
    Date
    [ Upstream commit d4fddac5a51c378c5d3e68658816c37132611e1f ]

    In test_firmware_init(), the buffer pointed to by the global pointer
    'test_fw_config' is allocated through kzalloc(). Then, the buffer is
    initialized in __test_firmware_config_init(). In the case that the
    initialization fails, the following execution in test_firmware_init() needs
    to be terminated with an error code returned to indicate this failure.
    However, the allocated buffer is not freed on this execution path, leading
    to a memory leak bug.

    To fix the above issue, free the allocated buffer before returning from
    test_firmware_init().

    Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
    Link: https://lore.kernel.org/r/1563084696-6865-1-git-send-email-wang6495@umn.edu
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    lib/test_firmware.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/lib/test_firmware.c b/lib/test_firmware.c
    index 83ea6c4e623cf..6ca97a63b3d6b 100644
    --- a/lib/test_firmware.c
    +++ b/lib/test_firmware.c
    @@ -886,8 +886,11 @@ static int __init test_firmware_init(void)
    return -ENOMEM;

    rc = __test_firmware_config_init();
    - if (rc)
    + if (rc) {
    + kfree(test_fw_config);
    + pr_err("could not init firmware test config: %d\n", rc);
    return rc;
    + }

    rc = misc_register(&test_fw_misc_device);
    if (rc) {
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-14 19:26    [W:4.028 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site