lkml.org 
[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 6/7] x86: KVM: svm: eliminate weird goto from vmrun_interception()
    On Tue, Aug 13, 2019 at 03:53:34PM +0200, Vitaly Kuznetsov wrote:
    > Regardless of whether or not nested_svm_vmrun_msrpm() fails, we return 1
    > from vmrun_interception() so there's no point in doing goto. Also,
    > nested_svm_vmrun_msrpm() call can be made from nested_svm_vmrun() where
    > other nested launch issues are handled.
    >
    > nested_svm_vmrun() returns a bool, however, its result is ignored in
    > vmrun_interception() as we always return '1'. As a preparatory change
    > to putting kvm_skip_emulated_instruction() inside nested_svm_vmrun()
    > make nested_svm_vmrun() return an int (always '1' for now).
    >
    > Suggested-by: Sean Christopherson <sean.j.christopherson@intel.com>
    > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    > ---

    Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>

    \
     
     \ /
      Last update: 2019-08-13 20:11    [W:8.891 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site