Messages in this thread | | | Date | Tue, 13 Aug 2019 16:55:09 +0200 | From | Daniel Vetter <> | Subject | Re: [PATCH 07/26] drm/dp_mst: Get rid of list clear in drm_dp_finish_destroy_port() |
| |
On Wed, Jul 17, 2019 at 09:42:30PM -0400, Lyude Paul wrote: > This seems to be some leftover detritus from before the port/mstb kref > cleanup and doesn't do anything anymore, so get rid of it. > > Cc: Juston Li <juston.li@intel.com> > Cc: Imre Deak <imre.deak@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Harry Wentland <hwentlan@amd.com> > Signed-off-by: Lyude Paul <lyude@redhat.com>
Maybe move this earlier, before patch 2. Either way:
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> --- > drivers/gpu/drm/drm_dp_mst_topology.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 0295e007c836..ec6865e1af75 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -3870,8 +3870,6 @@ static void drm_dp_tx_work(struct work_struct *work) > static inline void > drm_dp_finish_destroy_port(struct drm_dp_mst_port *port) > { > - INIT_LIST_HEAD(&port->next); > - > if (port->connector) > port->mgr->cbs->destroy_connector(port->mgr, port->connector); > > -- > 2.21.0 >
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
| |