lkml.org 
[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.2 013/123] ASoC: samsung: odroid: fix an use-after-free issue for codec
    Date
    From: Wen Yang <wen.yang99@zte.com.cn>

    [ Upstream commit 9b6d104a6b150bd4d3e5b039340e1f6b20c2e3c1 ]

    The codec variable is still being used after the of_node_put() call,
    which may result in use-after-free.

    Fixes: bc3cf17b575a ("ASoC: samsung: odroid: Add support for secondary CPU DAI")
    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Cc: Krzysztof Kozlowski <krzk@kernel.org>
    Cc: Sangbeom Kim <sbkim73@samsung.com>
    Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
    Cc: Liam Girdwood <lgirdwood@gmail.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Jaroslav Kysela <perex@perex.cz>
    Cc: Takashi Iwai <tiwai@suse.com>
    Cc: alsa-devel@alsa-project.org
    Cc: linux-kernel@vger.kernel.org
    Link: https://lore.kernel.org/r/1562989575-33785-2-git-send-email-wen.yang99@zte.com.cn
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/samsung/odroid.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/sound/soc/samsung/odroid.c b/sound/soc/samsung/odroid.c
    index e688169ff12ab..95c35e3ff3303 100644
    --- a/sound/soc/samsung/odroid.c
    +++ b/sound/soc/samsung/odroid.c
    @@ -275,9 +275,8 @@ static int odroid_audio_probe(struct platform_device *pdev)
    }

    of_node_put(cpu);
    - of_node_put(codec);
    if (ret < 0)
    - return ret;
    + goto err_put_node;

    ret = snd_soc_of_get_dai_link_codecs(dev, codec, codec_link);
    if (ret < 0)
    @@ -308,6 +307,7 @@ static int odroid_audio_probe(struct platform_device *pdev)
    goto err_put_clk_i2s;
    }

    + of_node_put(codec);
    return 0;

    err_put_clk_i2s:
    @@ -317,6 +317,8 @@ static int odroid_audio_probe(struct platform_device *pdev)
    err_put_cpu_dai:
    of_node_put(cpu_dai);
    snd_soc_of_put_dai_link_codecs(codec_link);
    +err_put_node:
    + of_node_put(codec);
    return ret;
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-08-14 04:11    [W:5.430 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site