Messages in this thread | | | Date | Tue, 13 Aug 2019 20:19:55 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream() |
| |
On Tue, Aug 13, 2019 at 07:29:50PM +0200, Cezary Rojewski wrote: > On 2019-08-13 18:52, Srinivas Kandagatla wrote: > > On 13/08/2019 17:03, Cezary Rojewski wrote: > > > On 2019-08-13 10:35, Srinivas Kandagatla wrote:
> > > > + if (dai->driver->ops->get_sdw_stream) > > > > + return dai->driver->ops->get_sdw_stream(dai, direction); > > > > + else > > > > + return ERR_PTR(-ENOTSUPP);
> > > Drop redundant else.
> > Not all the dai drivers would implement this function, I guess else is > > not redundant here!
> Eh. By that I meant dropping "else" keyword and reducing indentation for > "return ERR_PTR(-ENOTSUPP);"
The above is the idiom used throughout the rest of the file. [unhandled content-type:application/pgp-signature] | |