lkml.org 
[lkml]   [2019]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [alsa-devel] [PATCH 1/3] soundwire: add debugfs support
From
Date

>> #Cadence Objs
>> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
>> index 49f64b2115b9..89d5f1537d9b 100644
>> --- a/drivers/soundwire/bus.c
>> +++ b/drivers/soundwire/bus.c
>> @@ -49,6 +49,8 @@ int sdw_add_bus_master(struct sdw_bus *bus)
>> }
>> }
>>
>> + bus->debugfs = sdw_bus_debugfs_init(bus);
>> +
>
> It's "nicer" to just put that assignment into sdw_bus_debugfs_init().
>
> That way you just call the function, no need to return anything.

ok, thanks for the suggestion.

>
>> /*
>> * Device numbers in SoundWire are 0 through 15. Enumeration device
>> * number (0), Broadcast device number (15), Group numbers (12 and
>> @@ -109,6 +111,8 @@ static int sdw_delete_slave(struct device *dev, void *data)
>> struct sdw_slave *slave = dev_to_sdw_dev(dev);
>> struct sdw_bus *bus = slave->bus;
>>
>> + sdw_slave_debugfs_exit(slave->debugfs);
>
> Same here, just pass in slave:
> sdw_slave_debugfs_exit(slave);
> and have that function remove the debugfs entry in the structure. That
> way, if you are really paranoid about size, you could even drop the
> debugfs structure member from non-debugfs builds without any changes to
> bus.c or other non-debugfs files.

ok makes sense. will fix in v2.

\
 
 \ /
  Last update: 2019-08-12 15:25    [W:5.033 / U:2.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site