lkml.org 
[lkml]   [2019]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] perf diff: Report noisy for cycles diff
On Sat, Aug 10, 2019 at 07:30:29AM +0800, Jin Yao wrote:

SNIP

> + if (vals[i] != 0)
> + return 0;
> + return 1;
> +}
> +
> +static int print_cycles_spark(char *bf, int size, unsigned long *svals, u64 n)
> +{
> + int len = n, printed;
> +
> + if (len <= 1)
> + return 0;
> +
> + if (len > NUM_SPARKS)
> + len = NUM_SPARKS;
> + if (all_zero(svals, len))
> + return 0;
> +
> + printed = print_spark(bf, size, svals, len);
> + printed += scnprintf(bf + printed, size - printed, " ");
> +
> + if (n > NUM_SPARKS)
> + printed += scnprintf(bf + printed, size - printed, "..");

will this '..' ever be printed? I can't see that even if I enlarge
the column width..

jirka

\
 
 \ /
  Last update: 2019-08-12 10:37    [W:0.126 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site