| Subject | Re: [PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder | From | Stephen Boyd <> | Date | Mon, 12 Aug 2019 15:55:19 -0700 |
| |
Quoting Brendan Higgins (2019-08-12 11:24:06) > +void string_stream_clear(struct string_stream *stream) > +{ > + struct string_stream_fragment *frag_container, *frag_container_safe; > + > + spin_lock(&stream->lock); > + list_for_each_entry_safe(frag_container, > + frag_container_safe, > + &stream->fragments, > + node) { > + list_del(&frag_container->node);
Shouldn't we free the allocation here? Otherwise, if some test is going to add, add, clear, add, it's going to leak until the test is over?
> + } > + stream->length = 0; > + spin_unlock(&stream->lock); > +} > +
|