Messages in this thread | | | Date | Mon, 12 Aug 2019 16:05:07 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 3/3] driver/core: Fix build error when SRCU and lockdep disabled |
| |
On Mon, 12 Aug 2019 16:01:25 -0400 Joel Fernandes <joel@joelfernandes.org> wrote:
> > some/header/file.h: > > > > #ifdef CONFIG_DEBUG_LOCK_ALLOC > > # define CHECK_DEVICE_LINKS_READ_LOCK_HELD() WARN_ON_ONCE(!defice_links_read_lock_held()) > > #else > > # define CHECK_DEVICE_LINKS_READ_LOCK_HELD() do { } while (0) > > #endif > > > > And just use CHECK_DEVICE_LINK_READ_LOCK_HELD() in those places. I > > agree with Greg. "device_links_read_lock_heald()" should *never* > > blindly return 1. It's confusing. > > Ok, then I will update the patch to do: > > #ifdef CONFIG_DEBUG_LOCK_ALLOC > int device_links_read_lock_held(void) > { > return lock_is_held(&device_links_lock); > } > #endif > > That will also solve the build error. And callers can follow the above pattern you shared.
Sounds good!
-- Steve
| |